Refactor EpochMetric and make it idempotent#2800
Merged
vfdev-5 merged 15 commits intopytorch:masterfrom Feb 17, 2023
Merged
Conversation
Collaborator
|
Seems like there is a bug here: ignite/ignite/metrics/epoch_metric.py Lines 148 to 152 in 7c8d801
Thanks for catching that @sadra-barikbin ! |
vfdev-5
reviewed
Feb 15, 2023
vfdev-5
reviewed
Feb 16, 2023
sadra-barikbin
commented
Feb 16, 2023
3 tasks
vfdev-5
reviewed
Feb 17, 2023
vfdev-5
reviewed
Feb 17, 2023
vfdev-5
reviewed
Feb 17, 2023
sadra-barikbin
force-pushed
the
Refactor-EpochMetric-and-make-it-idempotent
branch
from
d3779e8 to
1f05f23
Compare
vfdev-5
reviewed
Feb 17, 2023
sadra-barikbin
force-pushed
the
Refactor-EpochMetric-and-make-it-idempotent
branch
from
10d7542 to
af77ead
Compare
vfdev-5
approved these changes
Feb 17, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks @sadra-barikbin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding an assertion to check recomputing metric does not change its result,
_test_distrib_integrationfails.